Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate from nx to workspaces #3455

Closed
wants to merge 1 commit into from
Closed

Conversation

castastrophe
Copy link
Collaborator

Description

Working to migrate off of NX as a build workflow tool in favor of the built-in system available in Yarn. Why? Fewer additional dependencies and more straight-forward tooling makes onboarding contributors easier. While NX does offer better caching services, yarn has a better user-experience for parallelizing on the command line.

This PR also defines certain constraints for our component packages. Constraints are a feature of Yarn that allows us to define properties for the package.json to keep them aligned and consistent.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 72ed5f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe force-pushed the build-migrate-off-nx branch 9 times, most recently from 8ec8f1c to cf8fda9 Compare December 19, 2024 20:39
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 2 times, most recently from c56b926 to 79eb129 Compare December 29, 2024 18:29
@castastrophe castastrophe force-pushed the build-migrate-off-nx branch 3 times, most recently from edd1094 to 853fc83 Compare January 3, 2025 03:19
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 3 times, most recently from d6c8c69 to 0116e9a Compare January 6, 2025 21:53
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 10 times, most recently from e9f4bbc to 99d17de Compare January 13, 2025 20:52
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 23 times, most recently from de25b2b to e747618 Compare January 28, 2025 16:02
Base automatically changed from s2-foundations-redux to main January 29, 2025 19:22
@castastrophe castastrophe removed the s1 label Feb 13, 2025
@castastrophe castastrophe force-pushed the build-migrate-off-nx branch from 4cc2196 to cfac3af Compare March 4, 2025 19:19
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Mar 4, 2025

🚀 Deployed on https://pr-3455--spectrum-css.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S2 Spectrum 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant